RE: [PATCH v8 4/4] mailbox: Add support for i.MX7D messaging unit
From: "A.s. Dong" <aisheng.dong@nxp.com>
Date: 2018-08-01 07:52:43
Also in:
linux-arm-kernel
From: "A.s. Dong" <aisheng.dong@nxp.com>
Date: 2018-08-01 07:52:43
Also in:
linux-arm-kernel
-----Original Message----- From: Oleksij Rempel [mailto:o.rempel@pengutronix.de] Sent: Tuesday, July 31, 2018 10:12 PM To: Shawn Guo <shawnguo@kernel.org>; Fabio Estevam [off-list ref]; Rob Herring [off-list ref]; Mark Rutland [off-list ref]; A.s. Dong [off-list ref]; Vladimir Zapolskiy [off-list ref]; Jassi Brar [off-list ref] Cc: Oleksij Rempel <o.rempel@pengutronix.de>; kernel@pengutronix.de; linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; dl-linux- imx [off-list ref] Subject: [PATCH v8 4/4] mailbox: Add support for i.MX7D messaging unit The Mailbox controller is able to send messages (up to 4 32 bit words) between the endpoints.
I'm not sure but is this still valid after change to multi channels mode? We actually lost the HW capability to send messages up to 4 words in the multi channels mode. And such commit message probably will confuse people. Worth a improve? Otherwise this patch mostly is okay to me except a few bits already pointed out by Jassi. Regards Dong Aisheng