Re: [PATCH 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr
From: Andrew Lunn <andrew@lunn.ch>
Date: 2018-08-27 20:35:12
Also in:
linux-arm-kernel, lkml
quoted hunk ↗ jump to hunk
@@ -210,6 +228,17 @@ reg = <4>; }; + port@5 { + label = "sfp"; + phy-mode = "sgmii"; + reg = <5>; + sfp = <&sfp>; + fixed-link { + speed = <1000>; + full-duplex; + };
Hi Florian
You might want to add a comment about why you are using fixed-link and
sgmii, which seems very odd. Is it even correct?
Andrew