Re: [PATCH 2/4] reset: qcom: PDC (Power Domain Controller) reset controller
From: Bjorn Andersson <hidden>
Date: 2018-08-21 22:17:47
Also in:
linux-arm-msm, linux-remoteproc, lkml
On Fri 27 Jul 08:28 PDT 2018, Sibi Sankar wrote:
quoted hunk ↗ jump to hunk
Add reset controller for SDM845 SoC to control reset signals provided by PDC for Modem, Compute, Display, GPU, Debug, AOP, Sensors, Audio, SP and APPS Signed-off-by: Sibi Sankar <redacted> --- drivers/reset/Kconfig | 9 +++ drivers/reset/Makefile | 1 + drivers/reset/reset-qcom-pdc.c | 139 +++++++++++++++++++++++++++++++++ 3 files changed, 149 insertions(+) create mode 100644 drivers/reset/reset-qcom-pdc.cdiff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index 13d28fdbdbb5..5344e202a630 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig@@ -98,6 +98,15 @@ config RESET_QCOM_AOSS reset signals provided by AOSS for Modem, Venus, ADSP, GPU, Camera, Wireless, Display subsystem. Otherwise, say N. +config RESET_QCOM_PDC + bool "Qcom PDC Reset Driver"
"Qualcomm" And I do not see a strong reason for this not being tristate, the consumers we've talked about so far can all be modules.
+ depends on ARCH_QCOM || COMPILE_TEST + help + This enables the PDC (Power Domain Controller) reset driver + for Qualcomm Technologies Inc SDM845 SoCs. Say Y if you want + to control reset signals provided by PDC for Modem, Compute, + Display, GPU, Debug, AOP, Sensors, Audio, SP and APPS. +
Implementation looks fine. Regards, Bjorn