Re: [PATCH 5/7] pinctrl: ingenic: Add support for the JZ4725B
From: Rob Herring <robh@kernel.org>
Date: 2018-08-17 15:10:01
Also in:
linux-gpio, lkml
Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Thu, 16 Aug 2018 18:35:42 +0200, Paul Cercueil wrote:
Add support for the JZ4725B and compatible SoCs from Ingenic. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
--- .../bindings/pinctrl/ingenic,pinctrl.txt | 2 + drivers/pinctrl/pinctrl-ingenic.c | 99 ++++++++++++++++++++++ 2 files changed, 101 insertions(+)
DT bindings (including binding headers) should be a separate patch. See Documentation/devicetree/bindings/submitting-patches.txt.