Hello Bjorn,


Can you please let us know the suggest the file name and review the patch.


On 7/9/2018 11:29 AM, Rohit Kumar wrote:

Thanks Rob for reviewing.


On 7/7/2018 2:02 AM, Rob Herring wrote:

quoted

On Fri, Jun 29, 2018 at 02:50:53PM +0530, Rohit kumar wrote:

quoted

This adds APSS based ADSP PIL driver for QCOM SoCs.
Added initial support for SDM845 with ADSP bootup and
shutdown operation handled from Application Processor
SubSystem(APSS).

Signed-off-by: Rohit kumar <redacted>
---
Changes since v1:
- Used APIs from qcom_q6v5.c
- Use clock, reset and regmap driver APIs instead of
   directly writing into the LPASS registers.
- Created new file for non PAS ADSP PIL instead of extending
   existing ADSP PIL driver.
- cleanups as suggested by Bjorn and Rob.

  .../bindings/remoteproc/qcom,non-pas-adsp.txt      | 138 +++++

This should be a separate patch.

Ok. Will separate it in next spin.

quoted

quoted

drivers/remoteproc/Kconfig                         |  18 +
  drivers/remoteproc/Makefile                        |   1 +
  drivers/remoteproc/qcom_nonpas_adsp_pil.c          | 667 
+++++++++++++++++++++
  4 files changed, 824 insertions(+)
  create mode 100644 
Documentation/devicetree/bindings/remoteproc/qcom,non-pas-adsp.txt
  create mode 100644 drivers/remoteproc/qcom_nonpas_adsp_pil.c

diff --git 

a/Documentation/devicetree/bindings/remoteproc/qcom,non-pas-adsp.txt 
b/Documentation/devicetree/bindings/remoteproc/qcom,non-pas-adsp.txt
new file mode 100644
index 0000000..0581aaa

--- /dev/null
+++ 

b/Documentation/devicetree/bindings/remoteproc/qcom,non-pas-adsp.txt

@@ -0,0 +1,138 @@
+Qualcomm Technology Inc. Non PAS ADSP Peripheral Image Loader
+
+This document defines the binding for a component that loads and 

boots firmware
+on the Qualcomm Technology Inc. ADSP Hexagon core.
+
+- compatible:
+    Usage: required
+    Value type: <string>
+    Definition: must be one of:
+            "qcom,sdm845-apss-adsp-pil"

Didn't Bjorn say to drop the 'apss' part?

Yes, he had asked to rename compatible string for  existing PIL driver 
as "qcom,platform-subsystem-pas"
and non-pas pil driver as "qcom,platform-subsystem-pil". I wanted to 
get confirmation from Bjorn whether
we should rename the filename too.
@Bjorn, can you please suggest filename and compatible strings for the 
two drivers.

quoted

quoted

+
+- reg:
+    Usage: required
+    Value type: <prop-encoded-array>
+    Definition: must specify the base address and size of the qdsp6ss
+
+- reg-names:
+    Usage: required
+    Value type: <stringlist>
+    Definition: must be "qdsp6ss"
+

-- 
To unsubscribe from this list: send the line "unsubscribe 
linux-remoteproc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Thanks,
Rohit