Re: [PATCH 1/2] dt: serial: Add Renesas RZ/N1 binding documentation

On Thu, Jul 12, 2018 at 12:05:21PM +0000, Phil Edworthy wrote:

Hi Geert,

On 11 July 2018 13:39, Geert Uytterhoeven wrote:

quoted

On Wed, Jul 11, 2018 at 2:30 PM Phil Edworthy wrote:

quoted

The RZ/N1 UART is a modified Synopsys DesignWare UART.
The modifications only relate to DMA so you could actually use the
controller with the Synopsys compatible string if you are not using
DMA, but you should not do so.

Signed-off-by: Phil Edworthy <redacted>

Thanks for your patch!

quoted

--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/renesas,rzn1-uart.txt

@@ -0,0 +1,10 @@
+Renesas RZ/N1 UART
+
+This controller is based on the Synopsys DesignWare ABP UART and
+inherits all properties defined in snps-dw-apb-uart.txt except for the

compatible property.

quoted

+
+Required properties:
+- compatible : The device specific string followed by the generic RZ/N1

string.

quoted

+   Therefore it must be one of:
+   "renesas,uart-r9a06g032", "renesas,uart-rzn1"

"renesas,r9a06g032-uart", "renesas,rzn1-uart"

quoted

+   "renesas,uart-r9a06g033", "renesas,uart-rzn1"

"renesas,r9a06g033-uart", "renesas,rzn1-uart"

I followed the renesas convention of renesas,peripheral-device that is used for
most R-Car drivers, but happy to change.

Please do. The "Renesas convention" is a hold over from early work on
DT bindings. The format Geert describes is now preferred.

quoted

I assume you plan to describe the DMA-related properties later?

Yes, it will take a while to sort out.