Thread (2 messages) 2 messages, 2 authors, 2018-07-10

Re: [PATCH v2] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB

From: Pierre Le Magourou <hidden>
Date: 2018-07-10 15:03:34
Also in: linux-usb

Hi Felipe,

2018-06-27 14:30 GMT+02:00 Felipe Balbi [off-list ref]:
looks like we need to do away with the wait_event_lock_irq()
call. usb_ep_dequeue() can be called from within the controller's
interrupt handler, so we can't rely on wait_event_lock_irq(). I guess
the best thing here would be to mark TRBs as dirty (and not increment
dequeue pointer), so they aren't reused by accident, then let endpoint
continue processing. Once command completion interrupt fires, we
increment dequeue pointer.

This should work better, I suppose. Do you want a shot at implementing
this?
I wrote a patch to implement this last week, and sent it to linux-arm-msm.
Feel free to review it and tell me if this complies with what you
suggested to me.

Regards,

Pierre Le Magourou
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help