On Sun, Jul 15, 2018 at 01:29:55PM +0800, Sean Wang wrote:

On Sat, 2018-07-14 at 18:27 +0200, Marcel Holtmann wrote:

quoted

Hi Sean,

quoted

In order to open up the required power gate before any operation can be
effectively performed over the serial bus between CPU and serdev, it's
clearly essential to add common attach functions for PM domains to serdev
at the probe phase.

Similarly, the relevant dettach function for the PM domains should be
properly and reversely added at the remove phase.

Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Reviewed-by: Ulf Hansson <redacted>
Cc: Rob Herring <robh@kernel.org>
Cc: Ulf Hansson <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <redacted>
Cc: linux-serial@vger.kernel.org
---
drivers/tty/serdev/core.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)

can we take this through the serial subsystem? Or should I just take it when the driver is ready to be included?

Regards

Marcel

I think it's better if the change is taken through serial subsystem
first.

Hi, Rob

do you have any comment? 

Yeah, I've been ignoring it to wait to get an ack from someone...

greg k-h