On Mon, Jul 09, 2018 at 01:45:22PM +0200, Linus Walleij wrote:
On Thu, Jul 5, 2018 at 3:43 PM Sergio Paracuellos
[off-list ref] wrote:
quoted
Add driver support for gpio of MT7621 SoC.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
This is looking really good.
Patch applied: anything remaining can surely be patched up
in-tree.
Sound good, thanks.
Should I send a patch to remove the driver from staging or just
is removed by Greg? How is this achieved?
quoted
+/*
+ * Copyright (C) 2009-2011 Gabor Juhos [off-list ref]
+ * Copyright (C) 2013 John Crispin [off-list ref]
+ */
All OpenWRT drivers are moving upstream and I like it :)
Gabo and John wrote like 90% of them on their own :D
quoted
+#define GPIO_BANK_WIDE 0x04
Nitpick: we usually call this "stride" rather than "wide".
I changed it while applying the patch.
Thanks :-)
Yours,
Linus Walleij
Best regards,
Sergio Paracuellos