On Thu, Jul 26, 2018 at 12:25:24PM -0700, Ray Jui wrote:

On 7/26/2018 12:16 PM, Arun Parameswaran wrote:

quoted

On 18-07-26 12:06 PM, Andrew Lunn wrote:

quoted

On Thu, Jul 26, 2018 at 11:36:19AM -0700, Arun Parameswaran wrote:

quoted

Modify the register offsets in the Broadcom iProc mdio mux to start
from the top of the register address space.

Earlier the base address specified was from the middle of the block's
register space. The base address will now point to the start of the
mdio's address space. The offsets have been fixed to match this.

Hi Arun

Did you consider a change something like:

That looks good. I will make this change to the patch.

Thanks
Arun

To make it backward compatible, then length of the resource also needs to be
adjusted from 0x14 to 0x250 in the driver?

Otherwise you will end up accessing areas out of 0x14 defined in old DT that
is not mapped?

struct resource {
       resource_size_t start;
       resource_size_t end;
       const char *name;
       unsigned long flags;
       unsigned long desc;
       struct resource *parent, *sibling, *child;
};

"end" suggests an address, not a length. But it would be good to look
deeper into the code to be sure.

       Andrew