On Sun, Jul 22, 2018 at 11:17 AM Jonathan Cameron [off-list ref] wrote:

On Sun, 22 Jul 2018 12:37:20 +0000
Brian Masney [off-list ref] wrote:

quoted

On Sat, Jul 21, 2018 at 06:37:16PM +0100, Jonathan Cameron wrote:

quoted

On Fri, 20 Jul 2018 11:36:35 -0600
Rob Herring [off-list ref] wrote:

quoted

On Tue, Jul 17, 2018 at 04:41:54AM -0400, Brian Masney wrote:

quoted

This patch adds support for optionally reading the prox_diode and
prox_power settings from device tree. This was tested using a LG
Nexus 5 (hammerhead) which requires a different diode than the driver
default for the IR LED.

Signed-off-by: Brian Masney <redacted>

quoted

quoted

quoted

quoted

+  - amstaos,prox_diode - must be TSL2772_DIODE0, TSL2772_DIODE1, or
+                         TSL2772_DIODE_BOTH.

s/_/-/

quoted

+  - amstaos,prox_power - must be TSL2772_100_mA, TSL2772_50_mA, TSL2772_25_mA,
+                         or TSL2772_13_mA.

I wonder if this should be common. Perhaps we should use the existing
'led-max-microamp' as this is setting the current for an IR LED.

Seems reasonable, then perhaps have two controls to turn on the diodes
above.

quoted

And while called 'power' this setting is current.

Also can we have real values?  I really don't like defines if they
aren't absolutely necessary - particularly when there is a nice real
unit to be used.

How about these options then?

amstaos,proximity-diode-0-enabled;
amstaos,proximity-diode-1-enabled;
led-max-microamp = <100000>;

Works for me.  Rob?

I think we're bikeshedding, but I'd prefer a single property though
perhaps as a list (0, 1, or <0 1>) or mask. A list would be similar to
the "led-sources" property format.

Rob