Thread (19 messages) read the whole thread 19 messages, 3 authors, 2018-07-19

Re: [PATCH RESEND 02/15] ASoC: meson: add axg fifo base driver

From: Jerome Brunet <jbrunet@baylibre.com>
Date: 2018-07-19 07:55:59
Also in: alsa-devel, linux-amlogic, lkml

On Wed, 2018-07-18 at 17:39 +0200, Takashi Iwai wrote:
On Wed, 18 Jul 2018 13:50:54 +0200,
Mark Brown wrote:
quoted
On Tue, Jul 17, 2018 at 05:42:51PM +0200, Jerome Brunet wrote:
quoted
+	return !status ? IRQ_NONE : IRQ_HANDLED;
Please just write normal conditional statements, it makes things a lot
easier to read (the ! isn't helping either here).
Indeed. I'll correct this in a follow up patch
... and there is the standard IRQ_RETVAL() macro for this purpose.
I was not aware of it. Thanks for the tip Takashi

Takashi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help