Thread (23 messages) 23 messages, 3 authors, 2018-07-27

Re: [PATCH 5/5] ARM: dts: exynos: add tmu aliases nodes

From: Anand Moon <hidden>
Date: 2018-07-17 19:56:34
Also in: linux-arm-kernel, linux-pm, linux-samsung-soc, lkml

Hi

On 17 July 2018 at 17:59, Krzysztof Kozlowski [off-list ref] wrote:
On 17 July 2018 at 12:12, Anand Moon [off-list ref] wrote:
quoted
add tmuctrl aliases node for exynos542x
Please use full sentence, starting with capital letter and ending with
a dot. Also please explain why you need tmuctrl aliases.
As per the [0] Documentation/devicetree/bindings/thermal/exynos-thermal.txt

For multi-instance tmu each instance should have an alias correctly
numbered in "aliases" node.
quoted
CC: Bartlomiej Zolnierkiewicz <redacted>
Signed-off-by: Anand Moon <redacted>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts         |  8 ++++----
 arch/arm/boot/dts/exynos5420.dtsi                  | 20 ++++++++++++--------
 arch/arm/boot/dts/exynos5422-odroid-core.dtsi      |  8 ++++----
 arch/arm/boot/dts/exynos5422-odroidhc1.dts         |  8 ++++----
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi |  8 ++++----
 arch/arm/boot/dts/exynos5800-peach-pi.dts          |  8 ++++----
 6 files changed, 32 insertions(+), 28 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 57c2332..ff79f0b 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -1061,19 +1061,19 @@
        status = "okay";
 };

-&tmu_cpu0 {
+&tmu_cpu_0 {
This looks irrelevant to the topic of adding aliases.
correct, I gone through the binding documentation and hence update this patch.

Best Regards
-Anand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help