Re: [PATCH 3/8] dt-bindings: regulator: document stpmu1 pmic regulators
From: Rob Herring <robh@kernel.org>
Date: 2018-07-16 22:21:33
Also in:
linux-input, linux-watchdog, lkml
On Thu, Jul 05, 2018 at 03:14:23PM +0000, Pascal PAILLET-LME wrote:
quoted hunk ↗ jump to hunk
From: pascal paillet <redacted> The STPMU1 regulators supply power to the application processor as well as to the external system peripherals such as DDR, Flash memories and system devices. Signed-off-by: pascal paillet <redacted> --- .../bindings/regulator/st,stpmu1-regulator.txt | 72 ++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/st,stpmu1-regulator.txtdiff --git a/Documentation/devicetree/bindings/regulator/st,stpmu1-regulator.txt b/Documentation/devicetree/bindings/regulator/st,stpmu1-regulator.txt new file mode 100644 index 0000000..888e759 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/st,stpmu1-regulator.txt@@ -0,0 +1,72 @@ +STMicroelectronics STPMU1 Voltage regulators + +Regulator Nodes are optional depending on needs. + +Available Regulators in STPMU1 device are: + - buck1 for Buck BUCK1 + - buck2 for Buck BUCK2 + - buck3 for Buck BUCK3 + - buck4 for Buck BUCK4 + - ldo1 for LDO LDO1 + - ldo2 for LDO LDO2 + - ldo3 for LDO LDO3 + - ldo4 for LDO LDO4 + - ldo5 for LDO LDO5 + - ldo6 for LDO LDO6 + - vref_ddr for LDO Vref DDR + - boost for Buck BOOST + - pwr_sw1 for VBUS_OTG switch + - pwr_sw2 for SW_OUT switch + +Switches are fixed voltage regulators with only enable/disable capability. + +Optional properties: +- st,mask_reset: stay on during Reset for particular regulator
s/_/-/ What's the type? 'mask' in the name makes it sound like a bitmask.
+- regulator-pull-down: enable high pull down
+ if not specified light pull down is used
+- regulator-over-current-protection:
+ if set, all regulators are switched off in case of over-current detection
+ on this regulator,
+ if not set, the driver only send an over-current event.
+- interrupt-parent: phandle to the parent interrupt controller
+- interrupts: index of current limit detection interrupt
+- <regulator>-supply: phandle to the parent supply/regulator node
+ each regulator supply can be described except vref_ddr.
+
+Example:
+regulators {
+ compatible = "st,stpmu1-regulators";
+
+ ldo6-supply = <&v3v3>;
+
+ vdd_core: regulator@0 {Drop the unit address.
+ regulator-compatible = "buck1"; + regulator-name = "vdd_core";
I think you have the names backwards here. Plus, regulator-compatible is not generally used.
+ interrupts = <IT_CURLIM_BUCK1 0>;
+ interrupt-parent = <&pmic>;
+ st,mask_reset;
+ regulator-pull-down;
+ st,pulldown_config = <2>;
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1200000>;
+ };
+
+ v3v3: buck4 {
+ regulator-compatible = "buck4";
+ regulator-name = "v3v3";
+ interrupts = <IT_CURLIM_BUCK4 0>;
+ interrupt-parent = <&mypmic>;
+
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ v1v8: ldo6 {
+ regulator-compatible = "ldo6";
+ regulator-name = "v1v8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-over-current-protection;
+ };
+
+};
--
1.9.1