Thread (50 messages) 50 messages, 6 authors, 2018-07-18

Re: [PATCH 06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC

From: Vinod <vkoul@kernel.org>
Date: 2018-07-09 17:15:12
Also in: dmaengine, linux-mips, lkml

On 03-07-18, 14:32, Paul Cercueil wrote:
The JZ4725B has one DMA core starring six DMA channels.
As for the JZ4770, each DMA channel's clock can be enabled with
a register write, the difference here being that once started, it
is not possible to turn it off.
ok so disable for this, right..
quoted hunk ↗ jump to hunk
@@ -204,6 +205,8 @@ static inline void jz4780_dma_chan_enable(struct jz4780_dma_dev *jzdma,
 {
 	if (jzdma->version == ID_JZ4770)
 		jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKES, BIT(chn));
+	else if (jzdma->version == ID_JZ4725B)
+		jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKE, BIT(chn));
but you are writing to a different register here.. 

-- 
~Vinod
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help