On Wed, Jul 4, 2018 at 9:14 AM Guodong Xu [off-list ref] wrote:

On Wed, Jul 4, 2018 at 2:54 AM Rob Herring [off-list ref] wrote:

quoted

On Fri, Jun 22, 2018 at 11:24:14AM +0800, Guodong Xu wrote:

quoted

From: Li Yu <redacted>

Add optional property dma_min_chan for k3dma.

Signed-off-by: Li Yu <redacted>
---
 Documentation/devicetree/bindings/dma/k3dma.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/t b/Documentation/devicetree/bindings/dma/k3dma.txt
index 4945aeac4dc4..2fa1370c3173 100644
--- a/Documentation/devicetree/bindings/dma/k3dma.txt
+++ b/Documentation/devicetree/bindings/dma/k3dma.txt

@@ -12,6 +12,11 @@ Required properties:
              have specific request line
 - clocks: clock required

+Optional properties:
+- dma_min_chan: the minimum number of DMA channel which begin to use
+             the default value is 0, but in some platform is
+             configured 1, like hi3660 platform

Can't this be implied by the compatible?

No. "hisilicon,k3-dma-1.0" can work with series of hisilicon kirin
SoC. And each has different reservation of channels for on-chip
coprocessors.

quoted

If not, needs vendor prefix and don't use '_' in property names.

Sure, thanks. Will change that when design new property. As Vinod
suggested, it makes sense to change this to a mask.

After checking with Kirin SoC design team, I prefer to stay with
minimum channel number instead of mask. So, I will change this
property to:

hisilicon,dma-min-chan

-Guodong

-Guodong

quoted

Rob