Thread (25 messages) 25 messages, 5 authors, 2018-06-28

Re: [PATCH v8 07/14] staging: typec: tcpci: remove unused tcpci_tcpc_config

From: Guenter Roeck <linux@roeck-us.net>
Date: 2018-06-27 00:31:17
Also in: linux-usb

On 06/26/2018 04:45 PM, Li Jun wrote:
Since we will use config settings via device properties, so
remove the hard code tcpci_tcpc_config.

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Li Jun <redacted>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
quoted hunk ↗ jump to hunk
---
  drivers/staging/typec/tcpci.c | 7 -------
  1 file changed, 7 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index e59547a..076498a 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c
@@ -464,17 +464,10 @@ static const struct regmap_config tcpci_regmap_config = {
  	.max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */
  };
  
-static const struct tcpc_config tcpci_tcpc_config = {
-	.type = TYPEC_PORT_DFP,
-	.default_role = TYPEC_SINK,
-};
-
  static int tcpci_parse_config(struct tcpci *tcpci)
  {
  	tcpci->controls_vbus = true; /* XXX */
  
-	/* TODO: Populate struct tcpc_config from ACPI/device-tree */
-	tcpci->tcpc.config = &tcpci_tcpc_config;
  	tcpci->tcpc.fwnode = device_get_named_child_node(tcpci->dev,
  							 "connector");
  	if (!tcpci->tcpc.fwnode) {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help