Re: [PATCH v3 4/4] arm64: dts: allwinner: a64: add SRAM controller device tree node

On Fri, Jun 15, 2018 at 4:39 AM, Icenowy Zheng [off-list ref] wrote:

于 2018年6月15日 GMT+08:00 上午1:27:21, "Jernej Škrabec" [off-list ref] 写到:

quoted

Dne četrtek, 14. junij 2018 ob 19:09:56 CEST je Jagan Teki napisal(a):

quoted

On Thu, Jun 14, 2018 at 9:05 PM, Chen-Yu Tsai [off-list ref] wrote:

quoted

From: Icenowy Zheng <redacted>

Allwinner A64 has a SRAM controller, and in the device tree

currently

quoted

quoted

we have a syscon node to enable EMAC driver to access the EMAC

clock

quoted

quoted

register. As SRAM controller driver can now export regmap for this
register, replace the syscon node to the SRAM controller device

node,

quoted

quoted

and let EMAC driver to acquire its EMAC clock regmap.

Signed-off-by: Icenowy Zheng <redacted>
[wens-jdAy2FN1RRM@public.gmane.org: Updated compatible string]
Signed-off-by: Chen-Yu Tsai <redacted>
---

 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19

+++++++++++++++++--

quoted

quoted

 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index
1b2ef28c42bd..87968dafe1dc 100644

--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

@@ -169,9 +169,24 @@

                ranges;

                syscon: syscon@1c00000 {

-                       compatible =

"allwinner,sun50i-a64-system-controller", -

quoted

quoted

"syscon";
+                       compatible =
"allwinner,sun50i-a64-system-control";

                        reg = <0x01c00000 0x1000>;

+                       #address-cells = <1>;
+                       #size-cells = <1>;
+                       ranges;
+
+                       sram_c: sram@18000 {
+                               compatible = "mmio-sram";
+                               reg = <0x00018000 0x28000>;
+                               #address-cells = <1>;
+                               #size-cells = <1>;
+                               ranges = <0 0x00018000 0x28000>;
+
+                               de2_sram: sram-section@0 {

So, this can attach to display-engine node through allwinner,sram and
add support to claim the sram on sun4i/sun4i_drv.c, correct?

Actually, it has to be added to display_clocks node and claimed in
drivers/
clk/sunxi-ng/ccu-sun8i-de2.c

Sorry it's old practice.

My new way is to add a bus driver which claims the SRAM.

Are you pointing this driver[1] ? if yes do we have recent version
patches for these changes so-that I can import.

[1] https://patchwork.kernel.org/patch/10290399/

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.