Thread (17 messages) 17 messages, 3 authors, 2018-07-13

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

From: Doug Anderson <dianders@chromium.org>
Date: 2018-06-27 16:28:10
Also in: linux-arm-kernel, linux-arm-msm, lkml

Hi,

On Wed, Jun 27, 2018 at 8:01 AM, Mark Brown [off-list ref] wrote:
On Tue, Jun 26, 2018 at 11:15:14AM -0700, Doug Anderson wrote:
quoted
I think he's still planning on re-shuffling his tree a bit.  When he
does this, do you need him to put the RPMh patches somewhere you can
merge into your tree?
Well, I *think* there's no actual dependency here since it's a new
driver with a Kconfig dependency.  It really just needs me to get round
to trawling through what's a fairly large patch with a troubled history
now you've reviewed it.
OK, great.  I guess I'm confused about the "|| COMPILE_TEST" causing
problems then?  I was worried that anyone trying to do "COMPILE_TEST"
on your tree (or linuxnext if RPMh isn't there) would get failures due
to the lack of header files.  I guess if it's a problem you could just
gut the "|| COMPILE_TEST" and it could be added back in later?

Hoping my reviews saved you time overall.

-Doug
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help