Re: [PATCH v2 1/2] dt-bindings: Add mtk-systimer bindings
From: Daniel Lezcano <hidden>
Date: 2018-06-27 08:20:45
Also in:
linux-mediatek, lkml
On 27/06/2018 09:53, Stanley Chu wrote:
Add binding documentation for the System Timer driver of the Mediatek SoCs. Signed-off-by: Stanley Chu <redacted> ---
quoted hunk ↗ jump to hunk
.../bindings/timer/mediatek,mtk-systimer.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-systimer.txtdiff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-systimer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-systimer.txt new file mode 100644 index 0000000..7a5bde6 --- /dev/null +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-systimer.txt@@ -0,0 +1,18 @@ +Mediatek System Timers +---------------------- + +Required properties: +- compatible: Should contain + "mediatek,sys_timer" for those platforms which support system timer. +- reg: Should contain the location and length for system timer registers. +- clocks: System timer is drived by system clock. + +Examples: + + sys_timer@10017000 { + compatible = "mediatek,sys_timer"; + reg = <0 0x10017000 0 0x1000>; + interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&sys_clk>; + }; +
Actually this binding already exists for mediatek timers, it is useless to add a new one. I note the binding in Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt contains: clocks = <&system_clk>, <&rtc_clk> However the existing driver does only use <&system_clk> AFAICT, I'm questioning if <&rtc_clk> is really needed. So, I suggest you sort out and fixup the rtc_clk thing (drop it) and then just add your new platform in the list in this binding. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog