于 2018年6月23日 GMT+08:00 下午10:06:27, Julian Calaby [off-list ref] 写到:

Hi Icenowy,

On Fri, Jun 22, 2018 at 10:49 PM Icenowy Zheng [off-list ref] wrote:

quoted

As we have all necessary parts to enable the DE2 CCU on the Allwinner
A64 SoC, add the needed device tree nodes, including the DE2 CCU

itself

quoted

and the DE2 bus.

The "mixer0-lcd0" simplefb device node is updated to use the DE2 CCU.

Signed-off-by: Icenowy Zheng <redacted>
---
Changes in v2:
- Drop SRAM controller device tree node addition (as it's already

added

quoted

  as part of syscon change.)
- Fix the clock reference in LCD SimpleFB.

 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 30

+++++++++++++++----

quoted

 1 file changed, 24 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

quoted

index ff2ddde1e117..318c4ba8ae9f 100644

--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

@@ -58,17 +60,12 @@
                #size-cells = <1>;
                ranges;

-/*
- * The pipeline mixer0-lcd0 depends on clock CLK_MIXER0 from DE2

CCU.

quoted

- * However there is no support for this clock on A64 yet, so we

depend

quoted

- * on the upstream clocks here to keep them (and thus CLK_MIXER0)

up.

quoted

- */
                simplefb_lcd: framebuffer-lcd {
                        compatible = "allwinner,simple-framebuffer",
                                     "simple-framebuffer";
                        allwinner,pipeline = "mixer0-lcd0";
                        clocks = <&ccu CLK_TCON0>,
-                                <&ccu CLK_DE>, <&ccu CLK_BUS_DE>;
+                                <&display_clocks CLK_MIXER0>;

Doesn't this technically break simplefb if this DT is used with a
Linux that doesn't have the display clock driver?

1. DT doesn't care forware compatibility.

2. This is a fix for not accurate HW representation. In
fact I have sent the DT with simplefb using DE2 CCU before, but
when they're pending, someone who just wants the simplefb
sent the not temporary version.This must be fixed.

Do we care about breaking that use-case?

Thanks,

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.