On Tue, Jun 19, 2018 at 5:49 PM Alan Stern [off-list ref] wrote:

On Tue, 19 Jun 2018 avifishman70@gmail.com wrote:

quoted

From: Avi Fishman <AviFishman70@gmail.com>

This patch adds support for ehci controller for the Nuvoton
npcm7xx platform.
Most of the code was taken from ehci-spear.c + specific initialization
code

Signed-off-by: Avi Fishman <AviFishman70@gmail.com>
---
 drivers/usb/host/Kconfig        |   8 ++
 drivers/usb/host/Makefile       |   1 +
 drivers/usb/host/ehci-npcm7xx.c | 212 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 221 insertions(+)
 create mode 100644 drivers/usb/host/ehci-npcm7xx.c

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 9f0aeb068acb..e3100b249f0f 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig

@@ -185,6 +185,14 @@ config USB_EHCI_MXC
      ---help---
        Variation of ARC USB block used in some Freescale chips.

+config USB_EHCI_HCD_NPCM7XX
+     tristate "Support for Nuvoton NPCM7XX on-chip EHCI USB controller"
+     depends on (USB_EHCI_HCD && ARCH_NPCM7XX) || COMPILE_TEST
+     default y

Are you sure this is what you want?  The value defaults to Y whenever
COMPILE_TEST is enabled?  Will that annoy people doing compile tests?

Do you recomment to change to:
default y if (USB_EHCI_HCD && ARCH_NPCM7XX)

Aside from that one issue,

Acked-by: Alan Stern <stern@rowland.harvard.edu>

Alan Stern