On Tue, May 22, 2018 at 02:19:21PM +0100, Rui Miguel Silva wrote:

Hi Sakari,
On Fri 18 May 2018 at 22:13, Sakari Ailus wrote:

quoted

On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote:

quoted

quoted

quoted

+endpoint node
+-------------
+
+- data-lanes    : (required) an array specifying active > >

physical

quoted

quoted

MIPI-CSI2
+		    data input lanes and their mapping to > > logical lanes;

the

quoted

quoted

+		    array's content is unused, only its > > length is

meaningful;

Btw. do note that you may get a warning due to this from the CSI-2 bus
property parsing code if the lane numbers are wrong.

quoted

quoted

quoted

+
+- fsl,csis-hs-settle : (optional) differential receiver > >

(HS-RX)

quoted

quoted

settle time;
Could you calculate this, as other drivers do? It probably >

changes

quoted

depending on the device runtime configuration.

The only reference to possible values to this parameter is given by
table in [0], can you point me out the formula for imx7 in the
documentation?

I don't know imx7 but the other CSI-2 drivers need no such system
specific
configuration.

Hum, I think there is at least one more (which this is compliant) that
also use this configuration parameter. [0]

Ah, that's where it then probably comes from, if the two hardware blocks share 
some bits.

I guess it's fine to keep it if you think it's really necessary.

-- 
Sakari Ailus
sakari.ailus@linux.intel.com