Hi Rob,
Thanks for your review, this and the other ones.
On Fri 18 May 2018 at 16:49, Rob Herring wrote:

On Fri, May 18, 2018 at 10:28:00AM +0100, Rui Miguel Silva 
wrote:

quoted

Add bindings documentation for i.MX7 media drivers.

Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
---
 .../devicetree/bindings/media/imx7.txt        | 125 
 ++++++++++++++++++
 1 file changed, 125 insertions(+)
 create mode 100644 
 Documentation/devicetree/bindings/media/imx7.txt

diff --git a/Documentation/devicetree/bindings/media/imx7.txt 

b/Documentation/devicetree/bindings/media/imx7.txt
new file mode 100644
index 000000000000..a26372630377

--- /dev/null
+++ b/Documentation/devicetree/bindings/media/imx7.txt

@@ -0,0 +1,125 @@
+Freescale i.MX7 Media Video Device
+==================================
+
+mipi_csi2 node
+--------------
+
+This is the device node for the MIPI CSI-2 receiver core in 

i.MX7 SoC. It is
+compatible with previous version of Samsung D-phy.
+
+Required properties:
+
+- compatible    : "fsl,imx7-mipi-csi2";
+- reg           : base address and length of the register set 
for the device;
+- interrupts    : should contain MIPI CSIS interrupt;
+- clocks        : list of clock specifiers, see
+ 
Documentation/devicetree/bindings/clock/clock-bindings.txt for 
details;
+- clock-names   : must contain "pclk", "wrap" and "phy" 
entries, matching
+                  entries in the clock property;
+- power-domains : a phandle to the power domain, see
+ 
Documentation/devicetree/bindings/power/power_domain.txt for 
details.
+- reset-names   : should include following entry "mrst";
+- resets        : a list of phandle, should contain reset 
entry of
+                  reset-names;
+- phy-supply    : from the generic phy bindings, a phandle to 
a regulator that
+	          provides power to MIPI CSIS core;
+- bus-width     : maximum number of data lanes supported (SoC 
specific);

This property is for parallel buses. Either just rely on 
data-lanes in 
the graph or this should be implied by the compatible.

Ack, will remove it.

quoted

+
+Optional properties:
+
+- clock-frequency : The IP's main (system bus) clock frequency 
in Hz, default
+		    value when this property is not specified is 
166 MHz;
+
+port node
+---------
+
+- reg		  : (required) can take the values 0 or 1, 
where 0 is the
+                     related sink port and port 1 should be 
the source one;
+
+endpoint node
+-------------
+
+- data-lanes    : (required) an array specifying active 
physical MIPI-CSI2
+		    data input lanes and their mapping to logical 
lanes; the
+		    array's content is unused, only its length is 
meaningful;
+
+- fsl,csis-hs-settle : (optional) differential receiver 
(HS-RX) settle time;

units and unit-suffix?

The information about this parameter is not much [0], but I think 
it
does not have units, it is the ratio between the Ths-settle and 
the
rx-clock period +/- constant.

quoted

+
+example:
+
+        mipi_csi: mipi-csi@30750000 {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                compatible = "fsl,imx7-mipi-csi2";
+                reg = <0x30750000 0x10000>;
+                interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+                clocks = <&clks IMX7D_IPG_ROOT_CLK>,
+                                <&clks 
IMX7D_MIPI_CSI_ROOT_CLK>,
+                                <&clks 
IMX7D_MIPI_DPHY_ROOT_CLK>;

quoted

+                clock-names = "pclk", "wrap", "phy";
+                clock-names = "mipi", "phy";

Err...

Yeah, thanks for notice it.

quoted

+                clock-frequency = <166000000>;
+                power-domains = <&pgc_mipi_phy>;
+                phy-supply = <&reg_1p0d>;
+                resets = <&src IMX7_RESET_MIPI_PHY_MRST>;
+                reset-names = "mrst";
+                bus-width = <4>;
+                fsl,csis-hs-settle = <3>;
+                fsl,csis-clk-settle = <0>;

Not documented.

It is the other way around, it should not be here in the example 
since
its value is always zero. [0] and I remove it from code and dts.

quoted

+
+                port@0 {
+                        reg = <0>;
+
+                        mipi_from_sensor: endpoint {
+                                remote-endpoint = 
<&ov2680_to_mipi>;
+                                data-lanes = <1>;
+                        };
+                };
+
+                port@1 {
+                        reg = <1>;
+
+                        mipi_vc0_to_csi_mux: endpoint {
+                                remote-endpoint = 
<&csi_mux_from_mipi_vc0>;
+                        };
+                };
+        };
+
+
+csi node
+--------

I'd prefer these split into 2 files.

Sure, will do it.

quoted

+
+This is device node for the CMOS Sensor Interface (CSI) which 
enables the chip
+to connect directly to external CMOS image sensors.
+
+Required properties:
+
+- compatible    : "fsl,imx7-csi";
+- reg           : base address and length of the register set 
for the device;
+- interrupts    : should contain CSI interrupt;
+- clocks        : list of clock specifiers, see
+ 
Documentation/devicetree/bindings/clock/clock-bindings.txt for 
details;
+- clock-names   : must contain "axi", "mclk" and "dcic" 
entries, matching
+                 entries in the clock property;

Need the OF graph details.

Ack, will add it in next version.

---
Cheers,
	Rui

[0]: https://community.nxp.com/thread/463777

quoted

+
+example:
+
+                csi: csi@30710000 {
+                        #address-cells = <1>;
+                        #size-cells = <0>;
+
+                        compatible = "fsl,imx7-csi";
+                        reg = <0x30710000 0x10000>;
+                        interrupts = <GIC_SPI 7 
IRQ_TYPE_LEVEL_HIGH>;
+                        clocks = <&clks IMX7D_CLK_DUMMY>,
+                                        <&clks 
IMX7D_CSI_MCLK_ROOT_CLK>,
+                                        <&clks 
IMX7D_CLK_DUMMY>;
+                        clock-names = "axi", "mclk", "dcic";
+
+                        port {
+                                csi_from_csi_mux: endpoint {
+                                        remote-endpoint = 
<&csi_mux_to_csi>;
+                                };
+                        };
+                };
-- 
2.17.0