Re: [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN
From: Tony Lindgren <tony@atomide.com>
Date: 2018-05-30 15:04:08
Also in:
linux-arm-kernel, linux-clk, linux-omap, lkml
* Faiz Abbas [off-list ref] [180530 14:12]:
The ti-sysc driver provides support for manipulating the idlemodes and interconnect level resets.
...
quoted hunk ↗ jump to hunk
--- a/arch/arm/boot/dts/dra76x.dtsi +++ b/arch/arm/boot/dts/dra76x.dtsi@@ -11,6 +11,25 @@ / { compatible = "ti,dra762", "ti,dra7"; + ocp { + + target-module@0x42c00000 { + compatible = "ti,sysc-dra7-mcan"; + ranges = <0x0 0x42c00000 0x2000>; + #address-cells = <1>; + #size-cells = <1>; + reg = <0x42c01900 0x4>, + <0x42c01904 0x4>, + <0x42c01908 0x4>; + reg-names = "rev", "sysc", "syss"; + ti,sysc-mask = <(SYSC_OMAP4_SOFTRESET | + SYSC_DRA7_MCAN_ENAWAKEUP)>; + ti,syss-mask = <1>; + clocks = <&wkupaon_clkctrl DRA7_ADC_CLKCTRL 0>; + clock-names = "fck"; + }; + }; + };
Looks good to me except I think the reset won't do anything currently with ti-sysc.c unless you specfify also "ti,hwmods" for the module? Can you please check? It might be worth adding the reset function to ti-sysc.c for non "ti,hwmods" case and that just might remove the need for any hwmod code for this module. Regards, Tony