Thread (7 messages) 7 messages, 4 authors, 2018-05-24

Re: [PATCH v3 5/6] spi: at91-usart: add driver for at91-usart as spi

From: Mark Brown <broonie@kernel.org>
Date: 2018-05-24 18:15:13
Also in: linux-arm-kernel, linux-serial, linux-spi, lkml

On Thu, May 24, 2018 at 07:04:11PM +0300, Radu Pirea wrote:
    if (ctlr->cs_gpios){
        spi->cs_gpio = ctlr->cs_gpios[spi->chip_select];
        if(gpio_is_valid(spi->cs_gpio))
            gpio_direction_output(spi->cs_gpio, !(spi->mode & SPI_CS_HIGH));

    }
You're expected to request the GPIOs in your driver using one of the
modern request functions like gpio_request_one() (or ideally the GPIO
descriptor APIs now) which combine the direction setting and request
into a single operation.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help