Re: [PATCH v6 4/6] ARM: dts: Renesas RZ/N1 SoC base device tree file
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2018-05-23 09:12:14
Also in:
linux-clk, linux-renesas-soc, lkml
Hi Michel, On Tue, May 22, 2018 at 12:01 PM, Michel Pollet [off-list ref] wrote:
This adds the Renesas RZ/N1D (Part #R9A06G032) SoC bare bone support. This currently only handles generic parts (gic, architected timer) and a UART. For simplicity sake, this also relies on the bootloader to set the pinctrl and clocks. Signed-off-by: Michel Pollet <redacted>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/arch/arm/boot/dts/r9a06g032.dtsi@@ -0,0 +1,86 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Base Device Tree Source for the Renesas RZ/N1D (R9A06G032) + * + * Copyright (C) 2018 Renesas Electronics Europe Limited + * + */ + +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/clock/rzn1-clock.h> + +/ { + compatible = "renesas,r9a06g032", "renesas,rzn1";
Please drop the "renesas,rzn1".
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clock RZN1_DIV_CA7>;I think the clocks property should be moved to the individual CPU nodes.
+
+ cpu@0 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0>;
+ };
+
+ cpu@1 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <1>;
+ };
+ };
The rest looks OK to me (pending acceptance of the clock bindings).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds