Hi Jacob, Shunqian,

On Thu, Mar 8, 2018 at 6:49 PM Jacob Chen [off-list ref] wrote:
[snip]

+static const struct of_device_id rkisp1_plat_of_match[] = {
+       {
+               .compatible = "rockchip,rk3288-cif-isp",
+               .data = &rk3288_isp_clk_data,
+       }, {
+               .compatible = "rockchip,rk3399-cif-isp",
+               .data = &rk3399_isp_clk_data,
+       },
+       {},
+};

We need MODULE_DEVICE_TABLE() here.

Best regards,
Tomasz