Thread (50 messages) 50 messages, 4 authors, 2018-05-04

Re: [PATCH v9 03/27] clk: davinci: psc: allow for dev == NULL

From: David Lechner <david@lechnology.com>
Date: 2018-05-02 01:49:59
Also in: linux-arm-kernel, linux-clk, lkml

On 05/01/2018 09:02 AM, Sekhar Nori wrote:
On Friday 27 April 2018 05:47 AM, David Lechner wrote:
quoted
+static inline void *_devm_kzalloc(struct device *dev, size_t size, gfp_t flags)
+{
+	if (dev)
+		return devm_kzalloc(dev, size, flags);
+
+	return kzalloc(size, flags);
+}
I have the same question on the utility of this. A memory allocation
error so early on is not going to result in a bootable system anyway.
So, I wonder if its better to just BUG() in such cases. That will
actually help faster debug than returning an error back. I know the push
back on using BUG(), but clock drivers are special, and I think thats
why its seems to be used quite a bit already.
Same reply here as well. On DA850/DA830, you might not get a console,
but you will "boot" even if one of the PSC devices fails though.

WARN() is probably just as good as BUG() in this case too.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help