Hi Geert,

Thanks for the feedback.

On Tue, Mar 27, 2018 at 4:37 PM, Biju Das [off-list ref] wrote:

quoted

Add support for RZ/G1C (R8A77470) SoC power areas to the R-Car SYSC
driver.

Signed-off-by: Biju Das <redacted>
Reviewed-by: Fabrizio Castro <redacted>

Thanks for your patch!

quoted

 drivers/soc/renesas/r8a7747x-sysc.c                | 29

++++++++++++++++++++++

While using "x" in drivers doesn't hurt, as it can be changed at any time later...

quoted

 include/dt-bindings/power/r8a7747x-sysc.h          | 22 ++++++++++++++++

... this is not true for DT bindings.

I know you do this to anticipate the use of this header file for r8a77471, which is
also called RZ/G1C, and identical to r8a77470, modulo a few on-SoC devices.
But using wildcards in DT bindings is a bad idea, as you cannot predict what e.g.
r8a77477 will be ;-)

So I'd settle for r8a77470-sysc.h. The actual defines in the file use
R8A77470_PD_* anyway.

 Will send V2 with the file name changed to r8a77470-sysc.h

BTW, I'm considering dropping all R8A*_PD_* definitions, as we can easily use
the numbers directly, cfr. module clock and interrupt numbers. That would be
one step closer to more .dtsi sharing.
The only thing that is keeping me back is that the value "32" (for the always-on
area) is not defined in the datasheet.

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
m68k.org

In personal conversations with technical people, I call myself a hacker. But when
I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.