Hi

-----Original Message-----
From: Mats Karrman [mailto:mats.dev.list@gmail.com]
Sent: 2018年3月30日 3:54
To: Jun Li <redacted>; robh+dt@kernel.org; gregkh@linuxfoundation.org;
heikki.krogerus@linux.intel.com; linux@roeck-us.net
Cc: a.hajda@samsung.com; shufan_lee@richtek.com; Peter Chen
[off-list ref]; devicetree@vger.kernel.org;
linux-usb@vger.kernel.org; dl-linux-imx [off-list ref];
devel@driverdev.osuosl.org
Subject: Re: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

Hi Li,

On 03/28/2018 06:06 PM, Li Jun wrote:

quoted

Add bingdings supported by current typec driver, so user can pass all
those properties via dt.

Signed-off-by: Li Jun <redacted>
---
 .../bindings/connector/usb-connector.txt           | 39

++++++++++++++++++++++

quoted

 1 file changed, 39 insertions(+)

diff --git
a/Documentation/devicetree/bindings/connector/usb-connector.txt
b/Documentation/devicetree/bindings/connector/usb-connector.txt
index e1463f1..922f22b 100644

--- a/Documentation/devicetree/bindings/connector/usb-connector.txt
+++ b/Documentation/devicetree/bindings/connector/usb-connector.txt

@@ -15,6 +15,29 @@ Optional properties:
 - type: size of the connector, should be specified in case of USB-A, USB-B
   non-fullsize connectors: "mini", "micro".

+Optional properties for usb-c-connector:
+- power-type: should be one of "source", "sink" or "dual"(DRP) if
+typec
+  connector has power support.
+- try-power-role: preferred power role if "dual"(DRP) can support
+Try.SNK
+  or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC.
+- data-type: should be one of "host", "device", "dual"(DRD) if typec
+  connector supports USB data.
+
+Required properties for usb-c-connector with power delivery support:
+- source-pdos: An array of u32 with each entry providing supported
+power
+  source data object(PDO), the detailed bit definitions of PDO can be
+found
+  in "Universal Serial Bus Power Delivery Specification" chapter
+6.4.1.2
+  Source_Capabilities Message, the order of each entry(PDO) should
+follow
+  the PD spec chapter 6.4.1. Required for power source and power dual role.
+- sink-pdos: An array of u32 with each entry providing supported
+power
+  sink data object(PDO), the detailed bit definitions of PDO can be
+found
+  in "Universal Serial Bus Power Delivery Specification" chapter
+6.4.1.3
+  Sink Capabilities Message, the order of each entry(PDO) should
+follow
+  the PD spec chapter 6.4.1. Required for power sink and power dual role.
+- op-sink-microwatt-hours: Sink required operating power in micro
+  watt-hours, if source offered power is less then it, Capability
+Mismatch
+  is set, required for power sink and power dual role.

This doesn't make sense. The unit of power is watt (W), watt-hour on the other
hand is a measurement of energy. I think "op-sink-microwatt" is what we want
here.

Yes, you are right, microwatt is what I should use here. I will change.

Li Jun

// Mats

quoted

+
 Required nodes:
 - any data bus to the connector should be modeled using the OF graph

bindings

quoted

   specified in bindings/graph.txt, unless the bus is between parent
node and @@ -73,3 +96,19 @@ ccic: s2mm005@33 {
 		};
 	};
 };
+
+3. USB-C connector attached to a typec port controller(ptn5110),
+which has power delivery support and enables drp.
+
+typec: ptn5110@50 {
+	...
+	usb_con: connector {
+		compatible = "usb-c-connector";
+		label = "USB-C";
+		power-type = "dual";
+		try-power-role = "sink";
+		source-pdos = <0x380190c8>;
+		sink-pdos = <0x380190c8 0x3802d0c8>;
+		op-sink-microwatt-hours = <9000000>;
+	};
+};

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel