Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power

Hi Simon,

On Mon, Mar 26, 2018 at 11:06 AM, Simon Horman [off-list ref] wrote:

On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote:

quoted

On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote:

quoted

quoted

quoted

On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
need to be kept powered when backup mode is enabled.  Reflect this in
the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.

The accessory power switch (SW23) is a toggle switch, hense specify
"rohm,rstbmode-level".

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Add rohm,rstbmode-level.
---
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 2a7f36abd2dd85c6..80794c38c2669d75 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi

@@ -376,6 +376,8 @@
              #interrupt-cells = <2>;
              gpio-controller;
              #gpio-cells = <2>;
+             rohm,ddr-backup-power = <15>;

  Why not 0xf if those are all bit flags?

Because it's a small number?
Does it matter?

   I think hex is preferable for the bit flags. Decimal makes one think it's something
else -- some magnitude, etc...

Geert, it seems that Rob Herring is of the same opinion.
Would you care to respin this series?

Sure, after the respun driver series has been accepted.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds