Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

On Mon, Mar 05, 2018 at 10:43:52AM +0000, Denis OSTERLAND wrote:

From: Michael Grzeschik <redacted>

We add support for the ISL1219 chip that got an integrated tamper
detection function. This patch implements the feature by adding
an additional timestamp0 file to sysfs device path.
This file contains seconds since epoch, if an event occurred,
or is empty, if none occurred.

The devicetree documentation for the ISL1219 device tree
binding is added with an short example. It is not a trivial
device, because it supports two interrupt souces.

Signed-off-by: Michael Grzeschik <redacted>
Signed-off-by: Denis Osterland <redacted>
---
 .../devicetree/bindings/rtc/isil,isl1219.txt       |  28 ++++

While preferred to separate, I'm not going to ask for that if there are 
no other changes on the binding.

Reviewed-by: Rob Herring <robh@kernel.org>

 drivers/rtc/rtc-isl1208.c                          | 160 ++++++++++++++++++---
 2 files changed, 171 insertions(+), 17 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1219.txt