Thread (16 messages) 16 messages, 6 authors, 2018-03-20

Re: [PATCH v2 2/3] gpiolib-of: Support 'reserved-gpio-ranges' property

From: Stephen Boyd <sboyd@kernel.org>
Date: 2018-03-01 21:50:04
Also in: linux-arm-kernel, linux-arm-msm, linux-gpio, lkml

Quoting Linus Walleij (2018-02-07 05:34:19)
Hi Stephen,

nice work!

On Fri, Jan 26, 2018 at 2:13 AM, Stephen Boyd [off-list ref] wrote:
quoted
For now, we plumb this into the gpiochip irq APIs so that
GPIO/pinctrl drivers can use the gpiochip_irqchip_irq_valid() to
test validity of GPIOs.
But is that the right thing to do, given that we just took the
trouble to define a DT binding that is explicitly about
any GPIO, not just IRQ capable ones?

I am worries that the *irq* infix etc on these functions
will be a bit confusing.

Is it a lot of work to make it just generic and maybe bake it
into the gpio_chip so as to refuse already in
gpiod_request_commit() in gpiolib already?
I don't think that it will be too much work to tweak the code to treat
these as gpios instead of irq lines. It may end up duplicating a bit of code
that the irq line stuff is already doing, but I'll take a stab at it and
see how bad it comes out.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help