Re: [PATCH v5 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver
From: Sudeep Holla <hidden>
Date: 2018-03-15 17:57:30
Also in:
linux-arm-kernel, lkml
From: Sudeep Holla <hidden>
Date: 2018-03-15 17:57:30
Also in:
linux-arm-kernel, lkml
On 15/03/18 17:53, Jolly Shah wrote:
Hi Sudeep,
[...]
quoted
It's opposite, you are just adding whole lot of functions/APIs here with out the users of those APIs. I am unable to visualise how they are getting used. So for me even if you just add handful of above APIs with drivers making call to each one of them along with it, I can better understand it. Without any usage of these APIs in this series, I fail to understand the need of it. So NACK to this patch without the users of the APIs introduced here.Ok. I will break series with users in next version.
Thanks. Don't add any APIs which are not used by drivers in the series. We don't want the whole set of APIs in that structure lying around in the kernel without users. -- Regards, Sudeep