[PATCH v2 09/12] staging: typec: tcpci: Only touch target bit when enable vconn
From: Li Jun <hidden>
Date: 2018-02-26 12:05:22
Also in:
linux-usb
Subsystem:
staging subsystem, the rest · Maintainers:
Greg Kroah-Hartman, Linus Torvalds
We need regmap_update_bits to avoid touch any other bits when enable or disable vconn. Signed-off-by: Li Jun <redacted> --- drivers/staging/typec/tcpci.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 7145771..27d53c6 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c@@ -213,14 +213,10 @@ static int tcpci_set_polarity(struct tcpc_dev *tcpc, static int tcpci_set_vconn(struct tcpc_dev *tcpc, bool enable) { struct tcpci *tcpci = tcpc_to_tcpci(tcpc); - int ret; - ret = regmap_write(tcpci->regmap, TCPC_POWER_CTRL, - enable ? TCPC_POWER_CTRL_VCONN_ENABLE : 0); - if (ret < 0) - return ret; - - return 0; + return regmap_update_bits(tcpci->regmap, TCPC_POWER_CTRL, + TCPC_POWER_CTRL_VCONN_ENABLE, + enable ? TCPC_POWER_CTRL_VCONN_ENABLE : 0); } static int tcpci_set_roles(struct tcpc_dev *tcpc, bool attached,
--
2.7.4