Re: [PATCH V4 2/2] thermal: imx: add i.MX7 thermal sensor support
From: Leonard Crestez <hidden>
Date: 2018-02-28 18:55:49
Also in:
linux-arm-kernel, linux-pm, lkml
From: Leonard Crestez <hidden>
Date: 2018-02-28 18:55:49
Also in:
linux-arm-kernel, linux-pm, lkml
On Sat, 2018-02-24 at 16:02 +0800, Anson Huang wrote:
This patch adds i.MX7 thermal sensor support, most of the i.MX7 thermal sensor functions are same with i.MX6 except the registers offset/layout, so we move those registers offset/layout definitions to soc data structure. i.MX7 uses single calibration data @25C, the calibration data is located at OCOTP offset 0x4F0, bit[17:9], the formula is as below: Tmeas = (Nmeas - n1) + 25; n1 is the fuse value for 25C. Signed-off-by: Anson Huang <redacted> Signed-off-by: Bai Ping <ping.bai@nxp.com>
On imx7d (also 6sx and 6ul) OCOTP read will hang silently if the ocotp
clk is not enabled. For example this can happen if imx_thermal is built
as a module or probes after unused clocks are disabled.
This driver has support for reading ocotp values through the ocotp
nvmem driver (which handles clks properly). Since imx7d is a new
compatible string for upstream maybe you could just make new-style
bindings mandatory and drop the changes to imx_init_from_tempmon_data?
See commit 2067b757e972 ("ARM: dts: imx6ul: Add imx6ul-tempmon")
--
Regards,
Leonard