Re: [PATCH v1 2/4] ASoC: codecs: pcm179x: Add support for PCM1789
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Date: 2018-02-27 21:56:33
Also in:
alsa-devel, lkml
Hello, On Tue, 27 Feb 2018 22:24:31 +0100, Mylène Josserand wrote:
quoted hunk ↗ jump to hunk
diff --git a/sound/soc/codecs/pcm179x-i2c.c b/sound/soc/codecs/pcm179x-i2c.c index 795a0657c097..83a2e1508df8 100644 --- a/sound/soc/codecs/pcm179x-i2c.c +++ b/sound/soc/codecs/pcm179x-i2c.c@@ -26,10 +26,13 @@ static int pcm179x_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id) { - struct regmap *regmap; + struct regmap *regmap = NULL;
I don't think this change is useful, since regmap is always initialized below anyway.
+ if (mute) + val = ~(PCM1789_MUTE_L_EN | PCM1789_MUTE_R_EN);
That's not really useful with regmap_update_bits() which already does the masking, no?
+ else + val = PCM1789_MUTE_L_EN | PCM1789_MUTE_R_EN; + ret = regmap_update_bits(priv->regmap, PCM1789_SOFT_MUTE, + PCM1789_MUTE_MASK, val);
Couldn't this be: if (mute) val = 0; else val = PCM1789_MUTE_MASK; ret = regmap_update_bits(priv->regmap, PCM1789_SOFT_MUTE, PCM1789_MUTE_MASK, val);
+static struct snd_soc_dai_driver pcm1789_dai = {
+ .name = "pcm1789-hifi",
+ .playback = {
+ .stream_name = "Playback",
+ .channels_min = 2,
+ .channels_max = 2,
+ .rates = SNDRV_PCM_RATE_CONTINUOUS,
+ .rate_min = 10000,
+ .rate_max = 200000,
+ .formats = PCM1792A_FORMATS, },Nit: the closing curly brace should be on a separate line.
+ if (type == PCM1789) + return devm_snd_soc_register_component(dev, + &soc_component_dev_pcm1789, + &pcm1789_dai, 1); +
Perhaps a "else" here ?
return devm_snd_soc_register_component(dev, &soc_component_dev_pcm179x, &pcm179x_dai, 1);
Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com