Thread (22 messages) 22 messages, 7 authors, 2018-03-17

Re: [PATCH v3 7/7] watchdog: coh901327: make use of timeout-secs provided in devicetree

From: Linus Walleij <hidden>
Date: 2018-02-22 14:01:34
Also in: linux-amlogic, linux-arm-kernel, linux-mediatek, linux-watchdog, lkml

On Sun, Feb 11, 2018 at 9:08 PM, Marcus Folkesson
[off-list ref] wrote:
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.

Following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt to make use of
the parameter logic.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---

Notes:
    v3:
        - Reformat and use coh901327_wdt.timeout instead of margin when print out
          timout in probe function.

    v2:
        - Set .timeout in coh901327_wdt structure declaration.
        - Set .min_timeout to 1 instead of 0. I could not find a datasheet
          for coh901327, so I'm not sure if 0 is valid. However, 0 seems
          wrong to me and most driver has 1 as min value. If it should
          be 0, please let me know and I have to set another initial
          value for margin.
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help