Thread (31 messages) 31 messages, 3 authors, 2018-02-19

Re: [PATCH v5 05/20] firmware: arm_scmi: add scmi protocol bus to enumerate protocol devices

From: Sudeep Holla <hidden>
Date: 2018-02-19 11:44:50
Also in: linux-arm-kernel, lkml


On 19/02/18 11:35, Arnd Bergmann wrote:
On Tue, Jan 2, 2018 at 3:42 PM, Sudeep Holla [off-list ref] wrote:
quoted
+#ifdef CONFIG_ARM_SCMI_PROTOCOL
+int scmi_driver_register(struct scmi_driver *driver,
+                        struct module *owner, const char *mod_name);
+void scmi_driver_unregister(struct scmi_driver *driver);
+#else
+static int scmi_driver_register(struct scmi_driver *driver,
+                               struct module *owner, const char *mod_name)
+{
+       return -EINVAL;
+}
+static void scmi_driver_unregister(struct scmi_driver *driver) {}
+#endif /* CONFIG_ARM_SCMI_PROTOCOL */
The dummy helpers must be 'static inline', not just 'static', otherwise you
get a warning when this header is included by a file that doesn't call
both of them.
Thanks, fixed locally now.

-- 
Regards,
Sudeep
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help