Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2018-02-14 13:58:37
Also in:
linux-arm-kernel, linux-renesas-soc, lkml
Hi Jacopo, On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi [off-list ref] wrote:
Add initial support for R-Car M3-N Salvator-x and r8a77965 SoC in device tree with cpg-mssr, reset and clock nodes. Add place-holder device nodes for all nodes referred by "salvator-common.dtsi" Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thanks for your patch!
Looks mostly fine to me.
P.S. scripts/dtc/dtx_diff arch/arm64/boot/dts/renesas/r8a7796{,5}-salvator-x.dtb
is your friend.
arch/arm64/Kconfig.platforms | 6 + arch/arm64/boot/dts/renesas/Makefile | 1 + .../arm64/boot/dts/renesas/r8a77965-salvator-x.dts | 30 ++ arch/arm64/boot/dts/renesas/r8a77965.dtsi | 495 +++++++++++++++++++++ 4 files changed, 532 insertions(+) create mode 100644 arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts create mode 100644 arch/arm64/boot/dts/renesas/r8a77965.dtsi
The maintainer will probably ask you to split this in three parts: - ARCH_R8A77965 - r8a77965.dtsi - r8a77965-salvator-x.dts
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts@@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2. +/* + * Device Tree Source for the Salvator-X board
with R-Car M3-N
+ *
+ * Copyright (C) 2018 Jacopo Mondi [off-list ref]
+ */
+
+/dts-v1/;
+#include "r8a77965.dtsi"
+#include "salvator-x.dtsi"
+
+/ {
+ model = "Renesas Salvator-X board based on r8a77965";
+ compatible = "renesas,salvator-x", "renesas,r8a77965";
+
+ aliases {
+ serial0 = &scif2;
+ };
+
+ chosen {
+ bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
+ stdout-path = "serial0:115200n8";
+ };Both aliases and chosen are already defined in salvator-common.dtsi, included via salvator-x.dtsi.
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi@@ -0,0 +1,495 @@ +// SPDX-License-Identifier: GPL-2. +/* + * Device Tree Source for the r8a77965 SoC + * + * Copyright (C) 2018 Jacopo Mondi <jacopo+renesas@jmondi.org> + * + * Based on r8a7796.dtsi + * Copyright (C) 2016 Renesas Electronics Corp. + */ + +#include <dt-bindings/clock/r8a77965-cpg-mssr.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/power/r8a77965-sysc.h> + +#define CPG_AUDIO_CLK_I R8A77965_CLK_S0D4 + +/ {
+ soc {
+ compatible = "simple-bus";
+ interrupt-parent = <&gic>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;+ timer {
+ compatible = "arm,armv8-timer";
+ interrupts = <GIC_PPI 13
+ (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 14
+ (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 11
+ (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 10
+ (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
+ };Please move the timer out of the soc node, as it does't have a unit address and a reg property.
+ pmu_a57 {
+ compatible = "arm,cortex-a57-pmu";
+ interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-affinity = <&a57_0>,
+ <&a57_1>;
+ };
Please move the pmu out of the soc node, as it does't have a unit address
and a reg property.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds