On Fri, Feb 09, 2018 at 10:22:16AM +0000, Cosmin Samoila wrote:

quoted

quoted

+static const char * const ak4458_dac_select_texts[] = { "OFF",
"ON" };

This looks like the users should be switch controls - what's the goal
here?

I think this is to allow users to switch off sound for all channels but
it seems silly to have 4 controls doing the same thing.
We now have two options:
- one control to switch off sound for all channels
- one controll per DAC

If they're mutes they shouldn't be in DAPM at all, just make them
standard controls - they should stack up with the matching volume
controls.

What do you mean by "users should be switch controls" ?
Should we use SND_SOC_DAPM_SWITCH instead of SND_SOC_DAPM_MUX?

They quite clearly aren't muxes so if they need to be in DAPM probably
switches but it's not clear that they need to be in DAPM.