Thread (25 messages) 25 messages, 6 authors, 2018-02-07

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

From: Rob Herring <hidden>
Date: 2018-02-06 20:36:33
Also in: linux-arm-kernel, linux-arm-msm, lkml

On Fri, Jan 26, 2018 at 4:18 PM, Stephen Boyd [off-list ref] wrote:
On 01/25, Rajendra Nayak wrote:
quoted
diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi
new file mode 100644
index 000000000000..b97f99e6f4b4
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi
@@ -0,0 +1,32 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ */
+
+&tlmm {
I'm not the maintainer, but I find this approach to the pins
really annoying. I have to flip to another file to figure out how
a board has configured the pins. And we may bring in a bunch of
settings that we don't ever use on some board too. Why can't we
put the settings in the board file directly?
FYI, there's a pending dtc change to allow deleting unreferenced nodes
which can solve the bloat problem.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help