On Mon, 2018-02-05 at 11:01 +0000, John Garry wrote:

On 04/02/2018 07:45, Rafael J. Wysocki wrote:

quoted

+       /* translate the I/O resources */

quoted

+       for (i = 0; i < count; i++) {
+               if (resources[i].flags & IORESOURCE_IO) {
+                       ret = acpi_translate_logicio_res(adev, host,
+                                                       &resources[i]);

You don't need to break this line as far as I'm concerned.

This is just to keep checkpatch happy. I could move the complete 
function call to a single line. And also shortening some symbols will help.

This could also use continue as well

	/* translate the I/O resources */
	for (i = 0; i < count; i++) {
		if (!(resources[i].flags & IORESOURCE_IO))
			continue;
		ret = acpi_translate_logicio_res(adev, host, &resources[i]);
		if (ret) {
			kfree(resources);
			dev_err(child, "Translate I/O range failed (%d)!\n",
				ret);
			return ret;
		}
	}