Hi Fabio, Andy,

Thanks a lot for your comments. I will address them and send v2.

Few comments inline.

On Mi, 2018-01-31 at 18:12 +0200, Andy Shevchenko wrote:

On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta [off-list ref] wrote:

quoted

AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC
for digital audio systems.

Signed-off-by: Junichi Wakasugi <redacted>
Signed-off-by: Mihai Serban <redacted>
Signed-off-by: Shengjiu Wang <redacted>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

4 authors of the code?!

The code has a very long history. I will add under each SoB the specific
contribution.

Mihai got the code from Junichi and reworked it for 4.9. Then Shengjiu and
me added various features and cleanups.

According to DCO [1] all SoB are valid and required.

quoted

+MODULE_AUTHOR("Junichi Wakasugi [off-list ref]");
+MODULE_AUTHOR("Mihai Serban [off-list ref]");

4 SoBs, 2 Authors. Please, fix accordingly.

Here I would prefer to list Junichi and Mihai because they were the main contributors.
Any other suggestion?

thanks,
Daniel.

[1] [1] https://developercertificate.org/
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel