Re: [PATCH 2/5] arm64: allwinner: a64: Add SPDIF TX pin to the A64

On Wed, Jan 24, 2018 at 7:00 PM, Maxime Ripard
[off-list ref] wrote:

On Wed, Jan 24, 2018 at 11:39:40AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:

quoted

From: Marcus Cooper <redacted>

Add the SPDIF TX pin to the A64 dtsi.

Signed-off-by: Marcus Cooper <redacted>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index c82979038b0b..db1694ec3ee4 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

@@ -336,6 +336,11 @@
                              drive-strength = <40>;
                      };

+                     spdif_tx_pins_a: spdif@0 {

This will generate a dtc warning, you should use a syntax similar to
the other nodes there (ie. spdif if that's the only muxing option, or
spdif-0).

Furthermore, if this is the only option, you should set it as the
default in the .dtsi, so boards don't have to, and possibly squash
this patch into the first one.

ChenYu