Re: [PATCH 14/15] usb: dwc3: Add disabling of start_transfer failure quirk

On Tue, Jan 9, 2018 at 2:45 AM, Felipe Balbi [off-list ref] wrote:

Hi,

Rob Herring [off-list ref] writes:

quoted

On Fri, Jan 05, 2018 at 12:16:02PM -0800, Thinh Nguyen wrote:

quoted

In DWC_usb31 version 1.70a-ea06 and prior needs a SW workaround for isoc
START TRANSFER command failure. However, some affected versions may have
RTL patches to fix this without a SW workaround. Add this quirk to
disable the SW workaround when it is not needed.

I really think this one should be implied by compatible strings.

won't work for dwc3. Core driver has a single compatible string, also
this wouldn't work for PCI-based implementations.

Then you will have to look at the parent node (this is why the way
DWC3 was split is wrong) or make the compatible strings more specific.
That is the purpose of compatible strings.

For PCI, don't you have different VID/PIDs? If not how would quirks
work for non-DT systems.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html