Re: [PATCH 4/4] dmaengine: qcom: bam_dma: Add num-ees dt binding for remotely controlled

Thanks for the review,

On 29/01/18 16:21, Rob Herring wrote:

On Tue, Jan 16, 2018 at 07:02:36PM +0000, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote:

quoted

From: Srinivas Kandagatla <redacted>

When Linux is master of BAM, it can directly read registers to know number
of supported execution enviroments, however when its remotely controlled
reading these registers would trigger a crash if the BAM is not yet
intialized/powered up on the remote side.

This patch adds new binding num-ees to specify supported number of
Execution Environments when BAM is remotely controlled.

Signed-off-by: Srinivas Kandagatla <redacted>
---
  Documentation/devicetree/bindings/dma/qcom_bam_dma.txt |  2 ++
  drivers/dma/qcom/bam_dma.c                             | 15 ++++++++++++---
  2 files changed, 14 insertions(+), 3 deletions(-)

The correct split is the binding changes in 1 patch. Driver changes
separate.

Sure, Will Split it in next version.

quoted

diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt b/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt
index aa6822cbb230..f0d10c2b393e 100644
--- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt
+++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt

@@ -17,6 +17,8 @@ Required properties:
    remote proccessor i.e. execution environment.
  - num-channels : optional, indicates supported number of DMA channels in a
    remotely controlled bam.
+- num-ees : optional, indicates supported number of Execution Environments in a
+  remotely controlled bam.

This one needs a vendor prefix as it is not a common property.

Make sense, I will change it in next version.

Thanks,
Srini

quoted

  
  Example:
  

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html