Hi Linus

On 01/15/2018 02:13 AM, Linus Walleij wrote:

On Fri, Jan 12, 2018 at 1:15 PM,  [off-list ref] wrote:

quoted

From: Patrice Chotard <redacted>

STM32F4 and STM32F7 MCUs has a SDIO controller that looks like
an ARM pl810.

PL180 you mean. Ulf can fix while applying.

I need to send a v2, i will fix it.

quoted

This patch adds the STM32 variant so that mmci driver supports it.

Signed-off-by: Andrea Merello <redacted>
Signed-off-by: Patrice Chotard <redacted>

(...)

quoted

+static struct variant_data variant_stm32 = {
+       .fifosize               = 32 * 4,
+       .fifohalfsize           = 8 * 4,
+       .clkreg                 = MCI_CLK_ENABLE,
+       .clkreg_enable          = MCI_ST_UX500_HWFCEN,

If the asic designed derived this from ux500 I guess it is proper.

quoted

+       .clkreg_8bit_bus_enable = MCI_ST_8BIT_BUS,
+       .clkreg_neg_edge_enable = MCI_ST_UX500_NEG_EDGE,
+       .datalength_bits        = 24,
+       .datactrl_mask_sdio     = MCI_DPSM_ST_SDIOEN,
+       .st_sdio                = true,

Did you test SDIO? I think we lack features for that.

no, the board accept only micro SD card, so only MMC mode can be tested.

quoted

+       {
+               .id     = 0x00880180,
+               .mask   = 0x00ffffff,
+               .data   = &variant_stm32,
+       },

Since ux500 was 480180 I wonder what variants 5,6,7 are...

What is the rule to define the id ? for ST Micro variants we got the 
list below :
	.id     = 0x00180180,  u300
	.id     = 0x10180180,  nomadik
	.id     = 0x00280180,  nomadik
	.id     = 0x00480180,  ux500
	.id     = 0x10480180,  ux500v2
	.id     = 0x00880180,  variant_stm32

I simply update the sixth digit for stm32 variant.


Patrice

Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij