Re: [patch v15 3/4] Documentation: jtag: Add bindings for Aspeed SoC 24xx and 25xx families JTAG master driver
From: Joel Stanley <joel@jms.id.au>
Date: 2018-01-11 17:50:45
Also in:
linux-api, linux-arm-kernel, linux-serial, lkml, openbmc
On Mon, Dec 25, 2017 at 3:53 AM, Oleksandr Shamray [off-list ref] wrote:
quoted hunk ↗ jump to hunk
It has been tested on Mellanox system with BMC equipped with Aspeed 2520 SoC for programming CPLD devices. Signed-off-by: Oleksandr Shamray <redacted> Signed-off-by: Jiri Pirko <redacted> Acked-by: Rob Herring <robh@kernel.org> --- v14->v15 v13->v14 v12->v13 v11->v12 v10->v11 v9->v10 v8->v9 v7->v8 Comments pointed by pointed by Joel Stanley [off-list ref] - Change compatible string to ast2400 and ast2000 V6->v7 Comments pointed by Tobias Klauser [off-list ref] - Fix spell "Doccumentation" -> "Documentation" v5->v6 Comments pointed by Tobias Klauser [off-list ref] - Small nit: s/documentation/Documentation/ v4->v5 V3->v4 Comments pointed by Rob Herring [off-list ref] - delete unnecessary "status" and "reg-shift" descriptions in bndings file v2->v3 Comments pointed by Rob Herring [off-list ref] - split Aspeed jtag driver and binding to sepatrate patches - delete unnecessary "status" and "reg-shift" descriptions in bndings file --- .../devicetree/bindings/jtag/aspeed-jtag.txt | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/jtag/aspeed-jtag.txtdiff --git a/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt b/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt new file mode 100644 index 0000000..8cfc610 --- /dev/null +++ b/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt@@ -0,0 +1,18 @@ +Aspeed JTAG driver for ast2400 and ast2500 SoC + +Required properties: +- compatible: Should be one of + - "aspeed,ast2400-jtag" + - "aspeed,ast2500-jtag" +- reg contains the offset and length of the JTAG memory + region +- clocks root clock of bus, should reference the APB clock +- interrupts should contain JTAG controller interrupt + +Example: +jtag: jtag@1e6e4000 { + compatible = "aspeed,ast2500-jtag"; + reg = <0x1e6e4000 0x1c>; + clocks = <&clk_apb>;
We've now got a proper clock driver upstream. Can you update the example to match the newly added bindings? clocks = <&syscon ASPEED_CLK_APB>; Cheers, Joel